fix: zellij attach when the -c / --create option is passed

[dsully]

assert_session_ne is called before the value of -c is known to create a session when attaching if it doesn't exist.

Move the call (and duplicate) to perform the session name validation, passing a boolean along to denote creation.

[pitoniak32]

I am not a maintainer but it seems that the start_client_plan is an arrow function definition. It is not actually called here. It is just defined in this scope to avoid needing to define it more than once. So I don't think this is a needed change

[dsully]

I'm not sure I understand. This is the only place that assert_session_ne is called.

[pitoniak32]

I know the issue was closed but it might be helpful for an explanation on what I mean. so the function assert_session_ne is called inside the following function. I was also using the wrong term for what they are considered in rust, arrow function is from javascript but rust they are closures you can check this article out
https://www.educative.io/answers/what-are-closures-in-rust

let start_client_plan = |session_name: std::string::String| {
    assert_session_ne(&session_name);
};

but the start_client_plan is just a variable that holds the closure that will call the assert_session_plan

`|session_name: std::string::String| assert_session_ne(&session_name);`

so this assert_session_ne is actually called here in the map function that will apply the function to the session name.

[dsully]

Thanks, “arrow function” threw me off. I’m very familiar with closures in other languages. 😎

[imsnif]

I really appreciate your efforts, but... #2247

[dsully]

Great, I searched but didn't find that one.