Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce crate size by 4.8MB using cargo diet, to 77kB #293

Merged
merged 2 commits into from Apr 22, 2021

Conversation

Byron
Copy link
Contributor

@Byron Byron commented Apr 21, 2021

Here is my call to action :D:
Screenshot 2021-04-21 at 09 25 07

On top of that I verified that cargo package is still able to build,
adjusting the includes in the process to assure required assets are
packaged, too.

I am happy to adjust the includes to your liking so we find a way to reduce the overall crate size.

On top of that I verified that `cargo package` is still able to build,
adjusting the includes in the process to assure required assets are
packaged, too.
@TheLostLambda
Copy link
Member

TheLostLambda commented Apr 21, 2021

This is awesome! Thanks for doing this, I'd never used includes before!

We can probably chop a little more if you'd like 🙂 Maybe something like:

 include = ["src/**/*", "assets/plugins/*", "assets/layouts/*", "LICENSE.md", "README.md", "!**/*_test.*", "!**/tests/**/*"]

The completions aren't really used by cargo install right now (only .deb and AUR packaging), so we don't need the build.rs for generating them or the completion assets themselves :)

If you chop those out too and make sure cargo package still works, I'm happy to merge this!

@Byron
Copy link
Contributor Author

Byron commented Apr 22, 2021

Even better :) - thanks for looking into this!

The fixes work as expected, and I am happy that zellij users will now get even faster installs via cargo.

Unsolicited and unrelated idea: "Expert mode" which disables on-screen key combinations and other help text.

@TheLostLambda TheLostLambda merged commit 5901214 into zellij-org:main Apr 22, 2021
@TheLostLambda
Copy link
Member

@Byron For a poor-man's "Expert Mode", you can modify your ~/.local/share/zellij/layouts/default.yaml (slightly different location on macOS) and remove the status-bar plugin 😉

---
direction: Horizontal
parts:
  - direction: Vertical
    split_size:
      Fixed: 1
    plugin: tab-bar
  - direction: Vertical
#  - direction: Vertical
#    split_size:
#      Fixed: 2
#    plugin: status-bar

For something a touch less hacky, it'd be great if you could open an issue! 🙂

@Byron
Copy link
Contributor Author

Byron commented Apr 22, 2021

Thanks for the hint! I think I will do that once I am actually an expert 😅.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants