fix(session): dead sessions without layout shouldn't be resurrectable #3167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedromfedricci
temporarily deployed
to
cachix
GitHub Actions
Inactive
|
Fixed by: #3264 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible for a dead session to not have a committed session-layout.kdl file, either because serialization is turned off, or because the session was killed before being flushed into disc. Since there isn't a file to load from, the session shouldn't be marked as resurrectable (for example, by the session-manager plugin), because its state is lost. As an example, the session-manager plugin will simply load the default layout for the dead session if selected, so it is just better to not list it at all.