Multiple users screen structs #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/github.com/imsnif/mosaic into multiple-users-screen-structs
…saic-org/mosaic into multiple-users-screen-structs
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an additional preparation for supporting multiple non-mirrored clients. This particular change changes the data structures in
Screento support multiple clients - specifically the active_tab_index and tab_history. It also changes most of the pty/screen instructions to specify the client_id which initiated the request.Right now the clients are mirrored "administratively". Meaning that (for example) when the screen changes tabs, it moves all clients from the focused tab to the new tab regardless of which one initiated the move.
This also fixes some issues discussed in #781