Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change duplicated client_id value name to underscore #984

Merged
merged 1 commit into from Jan 3, 2022
Merged

fix: change duplicated client_id value name to underscore #984

merged 1 commit into from Jan 3, 2022

Conversation

jaeheonji
Copy link
Member

@jaeheonji jaeheonji commented Jan 3, 2022 •
edited

This issue resolve #983

Fixed the problem that the client_id variable is not updated normally because it has the same name.
The client_id of plugin_map was re-assigned and it was not updated with the connected client_id.

@jaeheonji jaeheonji changed the title fix: change unused client_id value to underscore fix: change duplicated client_id value name to underscore Jan 3, 2022
imsnif
imsnif approved these changes Jan 3, 2022
View reviewed changes
Copy link
Member

@imsnif imsnif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, good find!!

@imsnif imsnif merged commit 5dd3fce into zellij-org:main Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imsnif imsnif imsnif approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic when switching tabs with a mouse click
2 participants
@jaeheonji @imsnif