-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A few quality of life updates #6
Conversation
victorprocure
commented
Jan 9, 2019
- Updated to support .NET core 3.0
- Streamlined build using paket and a new version of csproj files
- Added a Mode ability to select the style of indicator, so the user doesn't have to include default styles
- Add directory build props and targets to allow easier packing for nuget
Will be reviewing this once I have time! In the meantime people who want to use that version can just close and build from your Thank you so much for the collaboration! |
I don't use windows now-a-days, can anyone confirm this is fully working and backwards compatible and whatnot? |
@zeluisping LGTM 👍 Only one point. Do we need these new headers? |
@punker76 Can you explain what you mean by new headers? The link you provided is giving me the diff of the whole pull request and I'm not quite sure where to look at, specially since I am not up-to-date with modern C# practices |
Sorry, here is a better link... LoadingIndicators.WPF/src/LoadingIndicators.WPF/IndicatorVisualStateGroupNames.cs Lines 1 to 9 in 03fc84e
|
@victorprocure Would it be possible to remove these copyright headers? I want to keep everything in this repo under The Unlicense and by including that copyright this repo would now have code falling under two different licenses. I'm not asking this trying to disrespect your work, I greatly appreciate your contribution, just want this to be as clean as possible, from the start I wanted this project to be public domain and would like to keep it as such. Given that a company is mentioned in the copyright, I'd be willing to exchange some emails with a representative in case this copyright notice cannot be removed as to try and find another solution. |
Yeah, thats my bad, CodeMaid added them in, thought I got them out. I'll do it when I'm home |
Thought that would be the case, it's all good, remove it and then we'll proceed with the merge! |
Hi |
Hey @sigmarsson, I'm just waiting on @victorprocure to remove that copyright, I'll make a pull request to his fork to see if that'll be faster. Thank you for wanting to contribute! |
Sorry for the delay, been crazy busy. Hope thats good |
@zeluisping please merge, looks fine! |
Looking forward to the nuget package! |
@zeluisping Could you publish the latest master to NuGet? That would be great, thank you in advance! |