Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few quality of life updates #6

Merged
merged 6 commits into from
Sep 23, 2019
Merged

Conversation

victorprocure
Copy link
Contributor

  • Updated to support .NET core 3.0
  • Streamlined build using paket and a new version of csproj files
  • Added a Mode ability to select the style of indicator, so the user doesn't have to include default styles
  • Add directory build props and targets to allow easier packing for nuget

@zeluisping
Copy link
Owner

Will be reviewing this once I have time! In the meantime people who want to use that version can just close and build from your master

Thank you so much for the collaboration!

@zeluisping
Copy link
Owner

I don't use windows now-a-days, can anyone confirm this is fully working and backwards compatible and whatnot?

@punker76
Copy link

@zeluisping
Copy link
Owner

@punker76 Can you explain what you mean by new headers? The link you provided is giving me the diff of the whole pull request and I'm not quite sure where to look at, specially since I am not up-to-date with modern C# practices

@punker76
Copy link

punker76 commented Aug 1, 2019

@punker76 Can you explain what you mean by new headers? The link you provided is giving me the diff of the whole pull request and I'm not quite sure where to look at, specially since I am not up-to-date with modern C# practices

Sorry, here is a better link...

// --------------------------------------------------------------------------------------------------------------------
// <copyright file="IndicatorVisualStateGroupNames.cs" company="Procure Software Development">
// Copyright (c) 2019 Procure Software Development
// </copyright>
// <author></author>
// <summary>
//
// </summary>
// --------------------------------------------------------------------------------------------------------------------

@zeluisping
Copy link
Owner

zeluisping commented Aug 1, 2019

@victorprocure Would it be possible to remove these copyright headers? I want to keep everything in this repo under The Unlicense and by including that copyright this repo would now have code falling under two different licenses. I'm not asking this trying to disrespect your work, I greatly appreciate your contribution, just want this to be as clean as possible, from the start I wanted this project to be public domain and would like to keep it as such.

Given that a company is mentioned in the copyright, I'd be willing to exchange some emails with a representative in case this copyright notice cannot be removed as to try and find another solution.

@victorprocure
Copy link
Contributor Author

Yeah, thats my bad, CodeMaid added them in, thought I got them out. I'll do it when I'm home

@zeluisping
Copy link
Owner

Thought that would be the case, it's all good, remove it and then we'll proceed with the merge!

@sigmarsson
Copy link
Contributor

Hi
Will you accept this merge into the master ?
I wish to commit some changes too to add progress information.

@zeluisping
Copy link
Owner

Hey @sigmarsson, I'm just waiting on @victorprocure to remove that copyright, I'll make a pull request to his fork to see if that'll be faster. Thank you for wanting to contribute!

@victorprocure
Copy link
Contributor Author

Sorry for the delay, been crazy busy. Hope thats good

@xzessmedia
Copy link

@zeluisping please merge, looks fine!

@zeluisping zeluisping merged commit 65babec into zeluisping:master Sep 23, 2019
@brian-pickens
Copy link

Looking forward to the nuget package!

@Darki93
Copy link

Darki93 commented Mar 4, 2020

@zeluisping Could you publish the latest master to NuGet? That would be great, thank you in advance!

@zeluisping
Copy link
Owner

zeluisping commented Apr 6, 2022

I'll try to do this at some point, I've just merged #13 and would include that too. There's issue #15 to release a new version to NuGet (after closing the other issues).

If anyone wants to contribute, feel free to. I'll try to put some time into it, but I can't guarantee anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants