Skip to content
This repository has been archived by the owner on Nov 11, 2020. It is now read-only.

Commit

Permalink
Insights from Scrutinizer
Browse files Browse the repository at this point in the history
  • Loading branch information
Krzysztof Tomasz Zembrowski committed May 16, 2017
1 parent 83375e2 commit 480fbc3
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions src/Orange.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ class Orange
private $login_post_query_string = '?_DARGS=/ocp/gear/infoportal/portlets/login/login-box.jsp'; // login form POST query string
private $send_request_uri = '/portal/map/map/message_box?mbox_edit=new&mbox_view=newsms'; // request uri of form for sending new messages
private $send_post_request_uri = '/portal/map/map/message_box?_DARGS=/gear/mapmessagebox/smsform.jsp'; // action target for POST request of the sending new messages form
private $messages_request_uri = '/portal/map/map/message_box?mbox_view=sentmessageslist'; // request uri of the sent messages list
public $max_length = '640'; // max. length of one SMS message according to the sending new messages form

/**
Expand All @@ -36,7 +35,7 @@ public function __construct()
$session = new \Requests_Session($this->url);
$session->useragent = $this->user_agent;
$this->session = $session;
$response = $this->session->get($this->login_request_uri);
$this->session->get($this->login_request_uri);

$html = new \simple_html_dom();
$this->html = $html;
Expand Down Expand Up @@ -171,7 +170,7 @@ private function find($content, $selector, $nth = null)
* Checks the remaining SMS left this month from the response body
*
* @param string $content - content to be searched through
* @return boolean/int/string - free SMS this month; false if no content; int if int value present; other cases string
* @return boolean|int|string - free SMS this month; false if no content; int if int value present; other cases string
*/
private function free($content)
{
Expand Down

0 comments on commit 480fbc3

Please sign in to comment.