Clean up After Test DBs #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move db clean up to defer
zemirco
requested changes
Mar 15, 2017
zemirco
reviewed
Mar 15, 2017
| @@ -1724,6 +1729,7 @@ func TestSeed(t *testing.T) { | |||
| if _, err := client.Create(name); err != nil { | |||
| t.Error(err) | |||
| } | |||
| defer client.Delete(name) | |||
There was a problem hiding this comment.
The client.Delete at the end of the method can then be deleted, right?
There was a problem hiding this comment.
I deleted the Delete at the end of this method. Are you talking about this line?
https://github.com/zemirco/couchdb/pull/10/files#diff-51565ad50d7426213c2f33579f6f0e71L567
It looks like I missed one. I'll updated it.
There was a problem hiding this comment.
Yeah I was talking about the one you missed. I just could not create the comment at that line since you didn't touch it in your pull requests. GitHub just doesn't allow adding comments to lines which were not modified
zemirco
approved these changes
Mar 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up test dbs created during tests.
Moves current "deletes" to defer after creation, which prevents orphan dbs from being left behind when a test errors out.