Handle slashes in names #9
Conversation
|
Thank you! Will take a look within the next days. |
client_test.go
Outdated
| // The folllowing characters are valid in databse names: /_$()-+ | ||
| // However there is a known bug in couchdb with + (skipping + for testing) | ||
| // https://issues.apache.org/jira/browse/COUCHDB-1580 | ||
| validSpecialCharacter = "/_$()-/" |
There was a problem hiding this comment.
Do we need the trailing slash /? Isn't this character already tested with the first slash?
And is that documented somewhere which characters are allowed?
There was a problem hiding this comment.
Yeah we can remove the second slash.
http://docs.couchdb.org/en/1.6.0/api/database/common.html
The database name {db} must be composed by following next rules:
Name must begin with a lowercase letter (a-z)
Lowercase characters (a-z)
Digits (0-9)
Any of the characters _, $, (, ), +, -, and /.If you’re familiar with Regular Expressions, the rules above could be written as ^[a-z][a-z0-9_$()+/-]*$.
There was a problem hiding this comment.
For document id, I haven't been able to find any restrictions however...
client_test.go
Outdated
| @@ -17,6 +17,14 @@ import ( | |||
|
|
|||
| var client *Client | |||
|
|
|||
| const ( | |||
| // The folllowing characters are valid in databse names: /_$()-+ | |||
client_test.go
Outdated
| @@ -17,6 +17,14 @@ import ( | |||
|
|
|||
| var client *Client | |||
|
|
|||
| const ( | |||
| // The folllowing characters are valid in databse names: /_$()-+ | |||
Slashes in DB names should be escaped. The same is true for document ids.
I used PathEscape (in net/url) which is only available in go 1.8.
Also note, there is a known bug with couchdb not handling literal '+' in database names (and document ids). I'm not testing for this as it fails on couchdb's end.