Feature/super fields (for feature request #78) #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
{
fields: [
// Support label -> simple path
{
label: 'some label',
value: 'path.to.something'
},
// Support label -> derived value
{
label: 'some label', // Supporting duplicate labels
value: function(row) {
return row.path1 + row.path2;
}
},
// Support pathname -> pathvalue (label optional, keeps backwards compatibility)
'simplepath'
'path.to.value'
]
}
|
Also solves #71. Check https://github.com/azhang/json2csv/blob/feature/superFields/test/index.js#L318 for usage. |
|
I can merge once there is some documentation explaining this new feature 😄 |
|
Added! ^_^ Feel to make changes if you think something can be clearer. Also, does this require a major version update? Everything should be backwards compatible. |
|
I'm going to be doing a major bump any way, so this will make it into that. |
knownasilya
pushed a commit
that referenced
this pull request
Oct 8, 2015
Feature/super fields (for feature request #78)
|
Woot! Thanks! |
Closed
|
Sure. Do you have enough rights to do it or shall i do it? @azhang What's your npm username? |
|
No, I don't have enough rights. |
|
Npm username is azhang. Thanks a lot! |
$ npm owner ls json2csv
azhang <azhang@bottlenose.com>
knownasilya <ilya@burstcreations.com>
zemirco <mirco.zeiss@gmail.com>done. also added you to Collaborators. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#78
Allow params.fields to have more options. Supports
labelandpath.pathcan be a string path like before, or a function(row) to return a derived value.Should be mostly, if not completely, backwards compatible, as it passes all tests.