Feature/link extraction #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zemiret
reviewed
Apr 17, 2019
|
|
||
| object HeuristicExtractor { | ||
|
|
||
| val unlikelyClassCandidates: Array[String] = Array("-ad-", "ai2html", "banner", "breadcrumbs", "combx", "comment", "community", "cover-wrap", "disqus", "extra", "foot", "gdpr", "header", "legends", "menu", "related", "remark", "replies", "rss", "shoutbox", "sidebar", "skyscraper", "social", "sponsor", "supplemental", "ad-break", "agegate", "pagination", "pager", "popup", "yom-remote") |
There was a problem hiding this comment.
If you've made these two collections fields of a companion object, they can't be edited anyway, am I right? So maybe they should be immutable sequences?
Here is an entry on scala sequences: https://docs.scala-lang.org/overviews/collections/overview.html
There was a problem hiding this comment.
You are correct, I have addressed the issue. New patch no longer calls toArray after asScala as well.
|
Overall, there's not much to review in here. Looks good. |
zemiret
reviewed
Apr 18, 2019
src/main/scala/com/bsgenerator/extractor/article/HeuristicExtractor.scala
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.