This repository has been archived by the owner on Dec 22, 2023. It is now read-only.
Fix collection view controllers life cycle issue #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add special treatment for `UICollectionViewController`'s as their view is different from other core classes. Because `UICollectionViewController`'s view is an internal class (`UICollectionViewControllerWrapperView`), we need to cherry-pick by adding the collection view as the view that goes into `FamilyScrollView` and prepend the view controllers view (the internal class) to the bottom of the hierarchy so that it doesn't cover up the `FamilyScrollView`.
Codecov Report
@@ Coverage Diff @@
## master #190 +/- ##
=======================================
Coverage 80.11% 80.11%
=======================================
Files 11 11
Lines 835 835
=======================================
Hits 669 669
Misses 166 166
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
zenangst
deleted the
fix/collection-view-controllers-view-life-cycle-issue
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UICollectionViewController's as their view is different from other core classes.Because
UICollectionViewController's view is an internal class(
UICollectionViewControllerWrapperView), we need to cherry-pickby adding the collection view as the view that goes into
FamilyScrollViewand prepend the view controllers view (the internal class) to the bottom
of the hierarchy so that it doesn't cover up the
FamilyScrollView.