Skip to content
This repository has been archived by the owner on Dec 22, 2023. It is now read-only.

Improve safe area granularity setup #195

Merged
merged 1 commit into from
Sep 28, 2020

Conversation

ThomasLeblond
Copy link
Contributor

@ThomasLeblond ThomasLeblond commented Sep 28, 2020

Issue

Hello again 😅!

I have an issue about the constraints management. Top & Bottom are too close and for me this is missing granularity to handle top & bottom separately.

To explain, easier with an image!

Basic behavior with safeAreaLayoutConstraints at true

Simulator Screen Shot - iPhone 11 Pro Max - 2020-09-28 at 17 11 51

What's wrong for me? The blank space in bottom.

Basic behavior with safeAreaLayoutConstraints at false

Simulator Screen Shot - iPhone 11 Pro Max - 2020-09-28 at 17 12 19

What's wrong for me? The UINavigationBar is no more visible.

The solution. handle top & bottom safe area

Simulator Screen Shot - iPhone 11 Pro Max - 2020-09-28 at 17 11 28

🎉

@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2020

Codecov Report

Merging #195 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #195   +/-   ##
=======================================
  Coverage   80.11%   80.11%           
=======================================
  Files          11       11           
  Lines         835      835           
=======================================
  Hits          669      669           
  Misses        166      166           
Flag Coverage Δ
#iOS 43.00% <ø> (ø)
#macOS 80.11% <ø> (ø)
#tvOS 43.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdf9228...b3fbec3. Read the comment docs.

@zenangst
Copy link
Owner

Hey @ThomasLeblond, looks great… let's get this merged! 🏆

@zenangst zenangst merged commit 4c6748d into zenangst:master Sep 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants