This repository has been archived by the owner on Dec 22, 2023. It is now read-only.
Refactor UICollectionViewController support #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use `addSubview` rather than `insertSubview(at:)` to fix issue with navigation bars not collapsing properly - Disable user interactions and set background color to clear on internal collection view controllers wrapper view.
Codecov Report
@@ Coverage Diff @@
## master #196 +/- ##
=======================================
Coverage 81.45% 81.45%
=======================================
Files 11 11
Lines 836 836
=======================================
Hits 681 681
Misses 155 155
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addSubviewrather thaninsertSubview(at:)to fix issue withnavigation bars not collapsing properly
internal collection view controllers wrapper view.