Skip to content
This repository has been archived by the owner on Dec 22, 2023. It is now read-only.

Fix memory leak in FamilyViewControllerAttributes #197

Merged

Conversation

zenangst
Copy link
Owner

@zenangst zenangst commented Oct 7, 2020

  • Add weak to .nextAttributes .and .previousAttributes in
    FamilyViewControllerAttributes

Screen Shot 2020-10-07 at 14 14 06

- Add `weak` to `nextAttributes` .and `.previousAttributes` in
  `FamilyViewControllerAttributes`
@codecov-io
Copy link

codecov-io commented Oct 7, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@1eccba1). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #197   +/-   ##
=========================================
  Coverage          ?   81.33%           
=========================================
  Files             ?       11           
  Lines             ?      836           
  Branches          ?        0           
=========================================
  Hits              ?      680           
  Misses            ?      156           
  Partials          ?        0           
Flag Coverage Δ
#iOS 83.00% <ø> (?)
#macOS 80.14% <ø> (?)
#tvOS 43.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ources/Shared/FamilyViewControllerAttributes.swift 84.21% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1eccba1...455dedd. Read the comment docs.

@zenangst zenangst merged commit 02a9354 into master Oct 7, 2020
@zenangst zenangst deleted the fix/memory-leak-in-family-view-controller-attributes branch October 7, 2020 12:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants