Skip to content
This repository has been archived by the owner on Dec 22, 2023. It is now read-only.

Fix reloading issue when performing batch updates #205

Merged
merged 2 commits into from
Nov 5, 2020

Conversation

zenangst
Copy link
Owner

@zenangst zenangst commented Nov 5, 2020

  • Refactor performBatchUpdates in FamilyViewController to
    keep the layout transitions intact

- Refactor `performBatchUpdates` in `FamilyViewController` to
  keep the layout transitions intact
@codecov-io
Copy link

codecov-io commented Nov 5, 2020

Codecov Report

Merging #205 into master will decrease coverage by 2.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #205      +/-   ##
==========================================
- Coverage   79.72%   77.63%   -2.09%     
==========================================
  Files          12       12              
  Lines         863      863              
==========================================
- Hits          688      670      -18     
- Misses        175      193      +18     
Flag Coverage Δ
iOS 33.85% <ø> (-37.80%) ⬇️
macOS 77.63% <ø> (ø)
tvOS 33.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Sources/Shared/FamilySpaceManager.swift 54.83% <0.00%> (-32.26%) ⬇️
Sources/Shared/OSSignpostController.swift 0.00% <0.00%> (-22.23%) ⬇️
Sources/Shared/BinarySearch.swift 73.52% <0.00%> (-5.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 896ca93...294c3fa. Read the comment docs.

@zenangst zenangst merged commit b56a672 into master Nov 5, 2020
@zenangst zenangst deleted the fix/perform-batch-update-issue branch November 5, 2020 12:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants