Remove the use of .focusSection

Using `focusScope` has some pretty bad performance bottle-necks when it comes to lazy collections because it will render the entire list and through dequeuing out the window. This simply does not work as we want.
zenangst · May 25, 2023 · 0235f17 · 0235f17
1 parent ec77b01
commit 0235f17
Show file tree

Hide file tree

Showing 5 changed files with 0 additions and 9 deletions.
diff --git a/App/Sources/Views/ContentListView.swift b/App/Sources/Views/ContentListView.swift
@@ -54,9 +54,6 @@ struct ContentListView: View {
                 })
             }
             .focused($isFocused)
-            // This is a hack to avoid the extra padding that gets added when using `.focusSection`
-            .padding(.bottom, -8)
-            .focusSection()
             .onChange(of: isFocused, perform: { newValue in
               guard newValue else { return }
 

diff --git a/App/Sources/Views/EditableKeyboardShortcutsView.swift b/App/Sources/Views/EditableKeyboardShortcutsView.swift
@@ -103,7 +103,6 @@ struct EditableKeyboardShortcutsView: View {
               }
             }
           }
-          .focusSection()
           .padding(4)
         }
         Spacer()

diff --git a/App/Sources/Views/GroupsListView.swift b/App/Sources/Views/GroupsListView.swift
@@ -72,9 +72,6 @@ struct GroupsListView: View {
                 .tag(group)
             }
             .focused($isFocused)
-            // This is a hack to avoid the extra padding that gets added when using `.focusSection`
-            .padding(.bottom, -8)
-            .focusSection()
             .onChange(of: isFocused, perform: { newValue in
               guard newValue else { return }
 

diff --git a/App/Sources/Views/WorkflowApplicationTriggerView.swift b/App/Sources/Views/WorkflowApplicationTriggerView.swift
@@ -64,7 +64,6 @@ struct WorkflowApplicationTriggerView: View {
             focusPublisher.publish(element.id)
           }
         }
-        .focusSection()
         .onCommand(#selector(NSResponder.insertTab(_:)), perform: {
           focus.wrappedValue = .detail(.commands)
         })

diff --git a/App/Sources/Views/WorkflowCommandListView.swift b/App/Sources/Views/WorkflowCommandListView.swift
@@ -60,7 +60,6 @@ struct WorkflowCommandListView: View {
             }
           }
           .focused($isFocused)
-          .focusSection()
           .onChange(of: isFocused, perform: { newValue in
             guard newValue else { return }