Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation and tests #348

Merged
merged 9 commits into from
Nov 1, 2016
Merged

Improve documentation and tests #348

merged 9 commits into from
Nov 1, 2016

Conversation

zenangst
Copy link
Owner

This PR aims to slightly improve tests and the source code documentation.

It also resolves a Segfault that seems to have surfaced with Swift 3.0.1

1.	While type-checking 'observeValue' at Spots/Sources/iOS/Classes/SpotsScrollView.swift:115:17
2.	While type-checking expression at [Spots/Sources/iOS/Classes/SpotsScrollView.swift:127:19 - line:128:57] RangeText="keyPath == #keyPath(contentOffset)
          && (isDragging == false && isTracking == false)"

This seems to be resolved by guarding for keyPath and reversing the compare statement.

@@ -1,10 +1,10 @@
import UIKit

/// A proxy cell that is used for composite views inside other Spotable objects
class CarouselComposite: UICollectionViewCell, Composable {
public class CarouselComposite: UICollectionViewCell, Composable {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zenangst I see a lot of public in this PR 😄 Why is that?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The damn linter is complaint about comments on internal implementations.
Also some of the things probably should be public to being with ;)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would limit the amount of open and public to simplify the public API, so in the end there are only functionality that should be accessible. But if it's supposed to be public, then we're good here.

@vadymmarkov
Copy link
Collaborator

I see tests are failing 😄

@zenangst
Copy link
Owner Author

zenangst commented Nov 1, 2016

@vadymmarkov only on the damn PR... TRAVIS!!! 🔨

@zenangst
Copy link
Owner Author

zenangst commented Nov 1, 2016

And now the tests pass 🚦

@zenangst
Copy link
Owner Author

zenangst commented Nov 1, 2016

This will improve both #279 #290

@codecov-io
Copy link

codecov-io commented Nov 1, 2016

Current coverage is 69.99% (diff: 84.84%)

No coverage report found for master at 03c2eb0.

Powered by Codecov. Last update 03c2eb0...57e173f

Christoffer Winterkvist and others added 2 commits November 1, 2016 09:05
@vadymmarkov vadymmarkov merged commit fe9add2 into master Nov 1, 2016
@vadymmarkov vadymmarkov deleted the improve/internals branch November 1, 2016 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants