Internal improvements to both iOS and macOS #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
November 1, 2016 18:56
added 8 commits
November 2, 2016 21:06
|
@zenangst, thanks for your PR! By analyzing the history of the files in this pull request, we identified @onmyway133 and @vadymmarkov to be potential reviewers. |
zenangst
changed the title
|
Should improve test coverage for macOS #279 |
vadymmarkov
reviewed
Nov 2, 2016
| /// - parameter completion: A completion closure that runs when your updates are done. | ||
| public func reloadIfNeeded(_ changes: ItemChanges, withAnimation animation: Animation = .automatic, updateDataSource: () -> Void, completion: Completion) { | ||
| collectionView.process((insertions: changes.insertions, reloads: changes.reloads, deletions: changes.deletions), updateDataSource: updateDataSource) { | ||
| if changes.updates.isEmpty { |
There was a problem hiding this comment.
@zenangst Should we use weak self here?
|
|
||
| if item.size.width == 0.0 { | ||
| item.size.width = view.bounds.width | ||
| if item.size.height == 0.0 { item.size.height = itemView.preferredViewSize.height } |
There was a problem hiding this comment.
@zenangst I prefer start on the new line, just because it's easier to debug.
There was a problem hiding this comment.
I did this to fix the linting which... was a mistake 😎
I refactored it into it's own method now, without one-liners.
Current coverage is 69.77% (diff: 78.31%)@@ master #351 diff @@
==========================================
Files 57 58 +1
Lines 4236 4348 +112
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 2965 3034 +69
- Misses 1271 1314 +43
Partials 0 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the macOS implementation of Spots by adding the ability to reload with components.
SpotScrollViewto properly cleanup observers on subviews.beforeUpdateandafterUpdateonSpotableprotocol.Spotableobjects on macOS.