Rebuild subviewsInLayoutOrder based on subviews layout order. #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zenangst, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vadymmarkov and @onmyway133 to be potential reviewers. |
zenangst
changed the title
Current coverage is 58.44% (diff: 100%)@@ master #362 diff @@
==========================================
Files 47 47
Lines 2555 2558 +3
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 1492 1495 +3
Misses 1063 1063
Partials 0 0
|
zenangst
changed the title
|
@hyperoslo/ios this should be good now 😁 |
|
@zenangst Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found an issue where
subviewsInLayoutOrdercan be out of sync with the actual layout order in thecontentView. To fix this issue, the layout order is rebuilt based on thecontentVieworder when you add new views.This also moves observers into its own collection so that you cannot add or remove observers twice.