Initial implementation of improved focus for tvOS #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zenangst, thanks for your PR! By analyzing the history of the files in this pull request, we identified @onmyway133 to be a potential reviewer. |
Current coverage is 74.67% (diff: 22.72%)@@ master #408 diff @@
==========================================
Files 71 71
Lines 6163 6242 +79
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 4645 4661 +16
- Misses 1518 1581 +63
Partials 0 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial implementation to try to improve the focus on tvOS.
It features a new protocol called
SpotsFocusDelegatewhichControllerconforms to.The intention is that you can get the last focused view on screen. This is a restriction in the API as you can no longer set the
preferredFoucsedView.This implementation is not 100% complete but it is a good start.
I also attempted to improve how composites are reloaded. Right now the composite spots get replaced when ever a composite container is changed. There is potential for improvement here. However I ran into a weird crash related to
tableView(_ tableView: UITableView, didEndDisplaying cell: UITableViewCell, forRowAt indexPath: IndexPath).The stack trace can be found here.
https://gist.github.com/zenangst/1a7662f81e4abb0071a1bc88493e9fac
This happens when I try to get the prepared items from the temporary spot and add them to the already existing one.
The odd thing is, if you remove the delegate implementation, it reloads just fine.
Anyways, I think this is a good start.