Feature scroll view manager #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves the implementation for constraining horizontally scrollable components to not be vertically scrollable. It introduces the ScrollViewManager which handles the constraints plus the positioning of headers and footer views inside of a component.
Removes the knowledge about SpotScrollView in ScrollViewManager. Adds test for ScrollViewManager constraint method.
|
@zenangst, thanks for your PR! By analyzing the history of the files in this pull request, we identified @JohnSundell to be a potential reviewer. |
Codecov Report
@@ Coverage Diff @@
## master #652 +/- ##
==========================================
+ Coverage 87.57% 87.65% +0.07%
==========================================
Files 126 128 +2
Lines 10338 10413 +75
==========================================
+ Hits 9054 9128 +74
- Misses 1284 1285 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the implementation for constraining horizontally scrollable components to not be vertically scrollable. It introduces the ScrollViewManager which handles the constraints plus the
positioning of headers and footer views inside of a component.
I moved the code out of the delegate implementation to make it easier to test.