Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify SpotConfigurable #472

Closed
onmyway133 opened this issue Feb 8, 2017 · 3 comments
Closed

Clarify SpotConfigurable #472

onmyway133 opened this issue Feb 8, 2017 · 3 comments
Milestone

Comments

@onmyway133
Copy link
Sponsor Contributor

Hi, for now we have View adopting SpotConfigurable, which confuses, at least for me at first. Because SpotConfigurable involves something that can be configurable on the Spotable object, instead of the View

public protocol SpotConfigurable: ItemConfigurable {

  /// The perferred view size of the view.
  var preferredViewSize: CGSize { get }

  func prepareForReuse()
}
@zenangst
Copy link
Owner

zenangst commented Feb 9, 2017

@onmyway133 I totally agree, this is not the best naming. I think we can solve this by moving Item back into Spots and remove Brick as a dependency. Which means that we could just change ItemConfigurable to include the protocol declaration of SpotConfigurable.

@zenangst
Copy link
Owner

@onmyway133 it is now called ItemConfigurable, that clears things up doesn't it? 😎

@zenangst
Copy link
Owner

Feel free to cause the issue if you like.

@zenangst zenangst added this to the 6.0.0 milestone Mar 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants