Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v156: Multiple definitions of osh_updated_by function #2224

Closed
lat9 opened this issue Mar 23, 2019 · 2 comments
Closed

v156: Multiple definitions of osh_updated_by function #2224

lat9 opened this issue Mar 23, 2019 · 2 comments

Comments

@lat9
Copy link
Contributor

lat9 commented Mar 23, 2019

As reported in this Zen Cart posting, I blew it for the changes associated with #1342.

Pre-existing installations using zen_update_orders_history have that function defined in an /includes/functions/extra_function-based file. The extra functions are included by the init_general_functions.php processing which is, unfortunately, prior to the now in-core load of the functions_osh_update.php.

@lat9
Copy link
Contributor Author

lat9 commented Mar 23, 2019

That PR just pushed swaps the load of the functions_osh_update.php with init_general_functions.php, to allow that in-core version of the function to be defined prior to the load of the extra_functions files.

Any pre-existing definition of that function will no longer load, based on that now-previous definition.

drbyte added a commit that referenced this issue Mar 23, 2019
@drbyte
Copy link
Member

drbyte commented Mar 23, 2019

Closed by #2225

@drbyte drbyte closed this as completed Mar 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants