Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Admin page widget RecentOrdersDashboardWidget.php attribute query changes #3794

Closed
scottcwilson opened this issue Jul 27, 2020 · 5 comments

Comments

@scottcwilson
Copy link
Sponsor Contributor

As raised in
https://www.zen-cart.com/showthread.php?227011-Slow-admin-home-page-load

@drbyte
Copy link
Member

drbyte commented Jul 27, 2020

Thanks for transferring the concern here.

But is ”should not query” an accurate description, and outcome?

Excluding the attributes makes the data useless in stores that use them heavily, doesn’t it?

@scottcwilson scottcwilson changed the title Suggestion: Admin page widget RecentOrdersDashboardWidget.php should not query attributes Suggestion: Admin page widget RecentOrdersDashboardWidget.php attribute query changes Jul 27, 2020
@scottcwilson
Copy link
Sponsor Contributor Author

Perhaps the behavior could be switchable. Title updated.

@scottcwilson
Copy link
Sponsor Contributor Author

Alternately, perhaps the attribute query could be done in real time when the bubble is clicked. Even this could be optional, of course.

@JSWebSteve
Copy link

Excluding the attributes makes the data useless in stores that use them heavily, doesn’t it?

I'm not sure I would agree with this comment.

Surely the purpose of the bubble is to give a quick glance look at what an order contains. Nobody is going to pick and pack an order based on the content of that little bubble.
The site that the issue was identified on uses attributes for many of their products and the general product info in the bubble is sufficient to give a brief overview of the order content.

@JSWebSteve
Copy link

Alternately, perhaps the attribute query could be done in real time when the bubble is clicked. Even this could be optional, of course.

This seems like a sensible solution as it will limit the query to a single order.

drbyte added a commit that referenced this issue Oct 24, 2020
Edit the widget file and set `true` to `false` to exclude attributes

Fixes #3794
@drbyte drbyte closed this as completed in 636897f Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants