Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zen_get_category_tree no longer including 'Top' category when needed #5625

Closed
lat9 opened this issue Feb 23, 2023 · 0 comments · Fixed by #5626
Closed

zen_get_category_tree no longer including 'Top' category when needed #5625

lat9 opened this issue Feb 23, 2023 · 0 comments · Fixed by #5626

Comments

@lat9
Copy link
Contributor

lat9 commented Feb 23, 2023

With the zc158 update to move the definition of TOPMOST_CATEGORY_PARENT_ID into the non-db settings initialization, that value was changed from'0' to 0, changing its defined type.

That, unfortunately, rippled down into the admin so that

  1. The coupon-restrictions page no longer includes the 'Top' category in its dropdown.
  2. The copy_product admin sidebox no longer includes the 'Top' category in its dropdown (which it shouldn't unless there are already products in the top-level category).
  3. The move_product admin sidebox now operates in the same manner as the copy-product one.
  4. The 'Move category' sidebox no longer includes the 'Top' category in its dropdown, so you can no longer move a category's sub-category to the top-level.

Each of the above list of elements where the 'Top' category was missing-in-action was based on a variable-less call, e.g. zen_get_category_tree() flavored invocation.

Items 1 and 4 are corrected by simply restoring the TOPMOST_CATEGORY_PARENT_ID definition to its string type. Items 2 and 3 need some additional 'assistance' so that they don't offer the "Top" category as the location if there are not already products in the top-most category.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant