Provide the option of not going to 404 when product status is 0 #2551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing/feedback welcome |
|
@drbyte do you want me to put PRODUCT_THROWS_200_WHEN_DISABLED in the database? |
No, I wasn't planning on adding more config entries. The related discussion talked about this somewhat. |
|
Wondering if we should change the 404 to a 410 still. I am not strong on this - just wondering. |
|
In this PR the 404 is triggered if "product does not exist in database".
Thinking about it, I guess the latter is more likely to occur. |
Split out the code for handling 404 Header responses so it can be intercepted with an Observer if needed. Added ability to define a constant PRODUCT_THROWS_200_WHEN_DISABLED to boolean `true` without needing an Observer, if a Store wishes to allow a product to display even when disabled. A 404 will still trigger if the product doesn't actually exist in the db. A 410 can be triggered by setting `products_status` to `-1` in custom code, without needing an observer for the 410 response. This change should also reduce queries on product page. Fixes zencart#1699
drbyte
force-pushed
the
product-status-404-override
branch
from
4268f28
to
46ae2ee
Compare
zcwilt
approved these changes
Jul 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out the code for handling 404 Header responses so it can be intercepted with an Observer if needed.
Added ability to define a constant PRODUCT_THROWS_200_WHEN_DISABLED to boolean
truewithout needing an Observer, if a Store wishes to allow a product to display even when disabled.A 404 will still trigger if the product doesn't actually exist in the db.
A 410 can be triggered by setting
products_statusto-1in custom code, without needing an observer for the 410 response.This change should also reduce queries on product page.
Fixes #1699