Correct non-numeric value. #4166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using PHP 7.4+ and attempting to perform mathematical operations against an empty string (`''`), a warning message is generated about a non-numeric value being encountered as a result of the returned value from the price function `zen_get_discount_calc`. Although the thread where this was recently reported identifies problems with the output from that function, there are mathematical operations performed within the function that could also cause similar messages because the empty quote may be multiplied by a number which is expected to also generate a warning. This appears to resolve the issue identified at this specific post: https://www.zen-cart.com/showthread.php?227580-A-non-numeric-value-encountered-in-shopping_cart-php&p=1376008#post1376008
|
If not mistaken, isn't this already effectively addressed in #4153? Sorry if so and also if so covered/fixed then this could be closed. |
|
Aha! Yes! That's where I'd seen it. And that's why I thought we'd fixed it. Still, I think your suggested fix is also beneficial. |
drbyte
added a commit
to drbyte/zencart
that referenced
this pull request
Jan 8, 2021
|
Not where I can easily follow the additional code, so asking here, in the additional merges did the admin side also get updated? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using PHP 7.4+ and attempting to perform mathematical operations against an empty string (
''), a warning message is generated about a non-numeric value being encountered as a result of the returned value from the price functionzen_get_discount_calc. Although the thread where this was recently reported identifies problems with the output from that function, there are mathematical operations performed within the function that could also cause similar messages because the empty quote may be multiplied by a number which is expected to also generate a warning.This appears to resolve the issue identified at this specific post: https://www.zen-cart.com/showthread.php?227580-A-non-numeric-value-encountered-in-shopping_cart-php&p=1376008#post1376008