Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration settings for non-transactional email #4662

Merged
merged 1 commit into from Mar 4, 2022

Conversation

scottcwilson
Copy link
Sponsor Contributor

Allows newsletters, product notifications, back in stock mail, abandoned cart mail, etc. to be sent from an SMTP server designed for bulk emailing (rather than your regular email server).

Fixes #3886 as discussed with Chris.

@scottcwilson scottcwilson changed the title Introduces new settings for non-transactional email Configuration settings for non-transactional email Feb 24, 2022
@scottcwilson scottcwilson marked this pull request as draft February 25, 2022 12:02
@scottcwilson scottcwilson force-pushed the smtpauth_newsletters branch 2 times, most recently from 6471305 to a6f0a1a Compare February 25, 2022 12:18
@scottcwilson
Copy link
Sponsor Contributor Author

scottcwilson commented Feb 25, 2022

For documentation:

How to test this with your SMTP email server.

  • Modify NEWSLETTER_MODULES in Configuration > Email Settings so that the list includes direct_email.
  • Go to Customers > Customers and find your account. Press the email button and send yourself a test email.

This email will be delivered by the NEWSLETTER_EMAIL_SMTPAUTH_MAIL_SERVER.

@scottcwilson
Copy link
Sponsor Contributor Author

Verified using SendGrid as an external SMTP server.

@scottcwilson
Copy link
Sponsor Contributor Author

Verified using Mandrill as an external SMTP server.

@scottcwilson scottcwilson marked this pull request as ready for review February 26, 2022 22:43
@lat9 lat9 merged commit 6d73e87 into zencart:v158 Mar 4, 2022
@scottcwilson scottcwilson deleted the smtpauth_newsletters branch March 4, 2022 12:42
@torvista
Copy link
Member

torvista commented Mar 4, 2022

Once the upgrade script runs, these email templates
newsletters,product_notification,back_in_stock_notification,recover_cart_sale
will be sent using the credentials in the new fields....but there are none.

Just to be failsafe, should not the script either
copy the existing settings,
or there be a check on sending for the account name being "YourEmailAccountNameHere" / empty, to fallback to the default email settings?

@scottcwilson
Copy link
Sponsor Contributor Author

Once the upgrade script runs, these email templates ... will be sent using the credentials in the new fields....but there are none.

This is not correct. See line 215 of includes/functions/functions_email.php

@torvista
Copy link
Member

torvista commented Mar 5, 2022

Yes, I see it checks for content in NEWSLETTER_EMAIL_SMTPAUTH_MAIL_SERVER, which is an empty field by default.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Newsletter specific SMTP credentials
3 participants