Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NotifierManager::insertContent for easy content insertion. #6064
base: master
Are you sure you want to change the base?
Add NotifierManager::insertContent for easy content insertion. #6064
Changes from all commits
8e7daf2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This
else
clause might be skippable, since it's guarding against older/legacy observer syntax support.So if what's being built here won't ever need that legacy support, maybe the clause isn't needed.
Not that it's harmful to keep either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought this was still useful. If an observer registers interest in
CONTENT_FOO
and then does not declare a handler function, that's a bug that needs raising. Note that if thecontentDefinePageMap
contains a mapping, the loop iscontinue
d and the error would not be raised, as intended.Now I think about it, my 'sniff for define page' logic is poor implementation of the designedit removed some rubbish I wrote here :)FYI I have done a second take of development on a new branch, https://github.com/neekfenwick/zencart/tree/content-notifiers-take-two-issue-6053 as discussed in #6053 (comment) using suggestions from @lat9 to keep the new content notifier separate from NotifierManager, by instantiating a second global
$zcc_notifier
, similar to$zco_notifier
. This work was a little while ago and if it's actually more sensible to keep everything under one hood in NotifierManager I can back out that branch and stick to the original.