Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct ot_loworderfee PHP Deprecated log #6357

Merged
merged 1 commit into from
Mar 24, 2024

Conversation

lat9
Copy link
Contributor

@lat9 lat9 commented Mar 24, 2024

Seeing logs like

[24-Mar-2024 15:48:37 America/New_York] Request URI: /zc200w/index.php?main_page=checkout_payment, IP address: 127.0.0.1, Language id 1
#0 C:\xampp\htdocs\zc200w\includes\modules\order_total\ot_loworderfee.php(48): zen_debug_error_handler()
#1 C:\xampp\htdocs\zc200w\includes\classes\order_total.php(56): ot_loworderfee->__construct()
#2 C:\xampp\htdocs\zc200w\includes\modules\pages\checkout_payment\header_php.php(99): order_total->__construct()
#3 C:\xampp\htdocs\zc200w\index.php(35): require('C:\\xampp\\htdocs...')
--> PHP Deprecated: Creation of dynamic property ot_loworderfee::$enabled is deprecated in C:\xampp\htdocs\zc200w\includes\modules\order_total\ot_loworderfee.php on line 48.

Seeing logs like
```
[24-Mar-2024 15:48:37 America/New_York] Request URI: /zc200w/index.php?main_page=checkout_payment, IP address: 127.0.0.1, Language id 1
#0 C:\xampp\htdocs\zc200w\includes\modules\order_total\ot_loworderfee.php(48): zen_debug_error_handler()
#1 C:\xampp\htdocs\zc200w\includes\classes\order_total.php(56): ot_loworderfee->__construct()
#2 C:\xampp\htdocs\zc200w\includes\modules\pages\checkout_payment\header_php.php(99): order_total->__construct()
#3 C:\xampp\htdocs\zc200w\index.php(35): require('C:\\xampp\\htdocs...')
--> PHP Deprecated: Creation of dynamic property ot_loworderfee::$enabled is deprecated in C:\xampp\htdocs\zc200w\includes\modules\order_total\ot_loworderfee.php on line 48.
```
@drbyte drbyte merged commit 27a01ad into zencart:master Mar 24, 2024
8 checks passed
@proseLA
Copy link
Sponsor Contributor

proseLA commented Mar 26, 2024

enabled, sort_order, tax_class, etc...

is it perhaps time to create an abstract class that modules extend so that every module does not need to declare all of vars needed by the base zc code? it seems it applies to ot_total, shipping, and payment modules. or perhaps 3 needed abstract classes?

@lat9
Copy link
Contributor Author

lat9 commented Mar 26, 2024

enabled, sort_order, tax_class, etc...

is it perhaps time to create an abstract class that modules extend so that every module does not need to declare all of vars needed by the base zc code? it seems it applies to ot_total, shipping, and payment modules. or perhaps 3 needed abstract classes?

Agreed; that's been a sub-rosa topic of discussion for a follow-on release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants