Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use $psr4Autoload instead of config.core.php to handle the base class' loading #6541

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

lat9
Copy link
Contributor

@lat9 lat9 commented Jun 16, 2024

... thus enabling that class those classes to be overridden if needed.

... thus enabling that class to be overridden if needed.
@lat9 lat9 marked this pull request as draft June 17, 2024 16:53
@lat9 lat9 changed the title Add 'Customer.php` to the auto-loaded classes ... Use $psr4Autoload instead of config.core.php to handle the base class' loading Jun 17, 2024
Note that the shoppingCart class was modified to remove its `include_once` on the `upload` class in deference to simply auto-loading that class both storefront and admin.
@lat9 lat9 marked this pull request as ready for review June 17, 2024 21:55
@drbyte
Copy link
Member

drbyte commented Jun 18, 2024

Strictly speaking, no plugins should be directly modifying these files, because they should be providing their own autoload file for their own additional requirements.
In the case where they were intentionally altering the contents of these files, obviously this will be a breaking change for them, and they will need to revise their plugin accordingly.

@lat9 lat9 merged commit 1ab7e1c into zencart:master Jun 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants