Stargate token #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jovezen
pushed a commit
that referenced
this pull request
May 17, 2021
* updated message section - Token -> Coin - Chose right naming between Coins and Coin - Add validity check description - Remove unnecessary items in structs * token -> coin * update states section - token -> coin - remove SwapFeeRate, PoolFeeRate, BatchSize, LastBatchIndex in LiquidityPool struct * update state transition section - token -> coin * update end block section - token -> coin - delete CreateNewLiquidityPool process from end-block - delete description about LastBatchIndex - BatchSize is global parameter, not for each LiquidityPool * update event section - token -> coin - coins vs coin - remove unnecessary items * update params section - remove swap price function in LiquidityPoolTypes - change num_of_reserve_tokens to range_of_reserve_coin_num in LiquidityPoolTypes - add name to LiquidityPoolTypes - add LiquidityPoolCreationFee and UnitBatchSize * update readme token -> coin * Add Min, MaxReserveCoinNum, Fix indent Co-authored-by: nodebreaker0-0 <zeroday26@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry to the
Unreleasedsection inCHANGELOG.mdReviewed
Files changedin the github PR explorerFor Admin Use: