Fix for 1.9, expose Response#offset #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Ruby 1.8, hi[0] returns h has a byte. http://ruby-doc.org/core-1.8.7/String.html\#method-i-5B-5D In Ruby 1.9 and 2.x, #[] returns a slience http://www.ruby-doc.org/core-2.1.1/String.html\#method-i-5B-5D All versions respond to #bytes, so this change respresents a backwards compatible change and bugfix on newer Rubies closes zencoder#5
I found this to give a more accurate timestamp because the stamp is set immediately upon the wakeup that data is available, rather than after the data has been transfered to userspace. As a result, the timestamp is now passed into the Response object when it is constructed. closes zencoder#6
The test is quite hard if your clock is in sync. I'm not sure the right way to actually do this because we're using a pool of NTP servers and ntpdate and Net::NTP could hit different servers. I think this is good enough for now to verify that things actually work and return reasonable results. closes zencoder#6
|
Are you planning on releasing a new version? |
|
Just pushed a new version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5 describes how
String#[]is broken under Ruby > 1.8. This is fixed to work in all versions.#6 describes how
@client_time_receiveis not accessible and is an integer.In addition to these fixes, I've also swapped to using
IO#selectto get a more accurate timestamp reading and fixed the "Originating Timestamp" field to be based off a float.All tests pass on Rubies 1.8 .. 2.1 on my Ubuntu machine.