Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuel efficiency stats are calculated incorrectly #6

Closed
stharward opened this issue Feb 17, 2024 · 1 comment
Closed

fuel efficiency stats are calculated incorrectly #6

stharward opened this issue Feb 17, 2024 · 1 comment
Assignees

Comments

@stharward
Copy link

stharward commented Feb 17, 2024

In the UP_JET[1-4X] and SENSUIT tables, the Suit_Jetpack_Drain stat is inconsistent with the UI, and considered incorrectly in the "perfection" calculation.

Currently, the column has a value between 0 and 1. The value is the fraction of life support consumed by the jetpack for the equivalent usage; e.g., a value of 0.8 means that the jetpack uses 80% of the fuel it normally would. In the in-game UI, this is reported as +20% efficiency. So that means that for the values in the table, a lower Suit_Jetpack_Drain value is better; e.g., 0.8 is better than 0.95. The perfection calculation treats higher Suit_Jetpack_Drain values as better, which is wrong. You can see this comparing UP_SNSUIT seeds 28862 and 68868. 28862 has +29% fuel efficiency but ~0.28 perfection, and 68868 has +5% fuel efficiency but ~0.50 perfection.

The easiest fix is just to replace all the values in the column with 1-[Current Suit-Jetpack_Drain], and redo the perfection calculation.

@cengelha
Copy link
Member

Thanks for info! The transformations were already there but not triggered due to data type mismatch...
If fixed it in the latest commit (incl regeneration of the files)

@cengelha cengelha self-assigned this Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants