Mobile nav with new menu items #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- merges two navigations for mobile. Currently, we have a hamburger menu and a dropdown menu that's displayed when the user clicks on the avatar. - change the breakpoint for the mobile navbar. Currently, the mobile navbar is displayed only for mobile (width <= 768px). After these changes, mobile navbar will be displayed on both mobile and tablet viewports (width <= 1024px)
…ers' into jkopys/mobile-nav-with-new-menu-items
sergioazevedo
approved these changes
Dec 8, 2021
7 tasks
Anifacted
approved these changes
Dec 8, 2021
JakubKopys
force-pushed
the
jkopys/mobile-nav-with-new-menu-items
branch
from
0f057b6
to
ab584c3
Compare
zd-svc-github-copenhagen-theme
added a commit
that referenced
this pull request
Dec 13, 2021
# [2.13.0](v2.12.2...v2.13.0) (2021-12-13) ### Features * Mobile nav improvements and new menu items ([#285](#285)) ([1c851b0](1c851b0))
|
🎉 This PR is included in version 2.13.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a combination of 2 PRs: #283 and #284
Other changes:
User dropdown menu:
{{ t 'profile'}}in themy_profilehelper in order to update the wording from "My profile" to "Profile"."contributions"linker instead of the"my_activities"linker, since the "Request" link is added as a separate menu item."requests"linker.Requests page:
Contributions page
Subscriptions page
Screenshots
New navbar - admin:
https://user-images.githubusercontent.com/12835055/144049443-9870aaf6-cd5d-4cb2-8a03-e7048b215773.mov
New navbar - end user:
https://user-images.githubusercontent.com/12835055/144049466-8b5d1496-7883-43de-b205-0286ac5dc4b3.mov
Mobile nav screenshots:
Changed menu items screenshots:
Checklist