Adds rawMode to disable serializing localStorage values
#26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
Bump! Just wanted to check on this. NPR Visuals has been using it in production for several months now. |
|
+1 for this. Fyi you left a console.log floating in there. |
|
Thanks for the PR! I've replied to #21 I think what I'd rather see is the removal of serialization from |
|
Thanks again! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been integrating cross-storage with a localStorage ecosystem that does not serialize its values; thus, we needed a way to use cross-storage that did not depend on serialization. This PR adds a configuration option to the client init called
rawModethat will make getting/setting values not rely on serialization.Another way to do this would be to use native ES6 classes and create a
rawCrossStorageClientsubclass.See #21 for more.