-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce additional CKEditor theming #5
Conversation
76e36f2
to
cd86a6c
Compare
@austingreendev Based on your listed changes, all looks kosher to me! The only thing I'm wondering about is whether the chevron in the Heading dropdown menu is vertically center-aligned with the Heading text, it looks slightly off center. |
Agreed. I'll take a look at the vertical spacing there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a few questions but LGTM!
@@ -1,3 +1,5 @@ | |||
.ck-content hr { | |||
margin: var(--ck-spacing-unit) 0; | |||
margin: var(--ck-spacing-extra-large) 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There might need to be a notion of padding if border-radius
focus is to be applied to this element.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated the horizontal line spacing to match the expected focus-ring size. I'll update any required padding/margin when we handle all of the content spacing in a following PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍
Description
This PR adds additional CKEditor theming. Its scope is limited to basic styling and doesn't attempt to override any layout, spacing, or advanced functionality at this time.
Detail
Some core areas to focus on are:
alt+F10
focus states for icon buttons and list focus state.