Address JZ comments

zendeskgarden · Sep 11, 2020 · 7a81311 · 7a81311
1 parent fecb2e8
commit 7a81311
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -46,6 +46,7 @@ jobs:
     steps:
       - *attach_workspace
       - run: yarn build:storybook
+      - run: yarn lerna run build:demo --concurrency=1 # prevent out-of-memory
       - run: utils/scripts/deploy.js
 
   publish:

diff --git a/.storybook/gardenTheme.js b/.storybook/gardenTheme.js
@@ -9,7 +9,7 @@ import { create } from '@storybook/theming/create';
 import { DEFAULT_THEME } from '../packages/theming/src';
 
 export const managerTheme = create({
-  base: 'light',
+  base: 'dark',
   fontBase: DEFAULT_THEME.fonts.system,
   fontCode: DEFAULT_THEME.fonts.mono,
   brandTitle: 'React Components / Zendesk Garden',

diff --git a/.storybook/preview.js b/.storybook/preview.js
@@ -12,13 +12,16 @@ import { ThemeProvider, DEFAULT_THEME } from '../packages/theming/src';
 
 export const parameters = {
   actions: { argTypesRegex: '^on[A-Z].*', layout: 'centered' },
+  backgrounds: { disable: true },
   docs: {
     theme: previewTheme
   }
 };
 
 const GlobalPreviewStyling = createGlobalStyle`
   body {
+    background-color: ${p => p.theme.colors.background};
+    color: ${p => p.theme.colors.foreground};
     font-family: ${p => p.theme.fonts.system};
     font-size: ${p => p.theme.fontSizes.md};
   }
@@ -70,8 +73,8 @@ export const globalTypes = {
     toolbar: {
       icon: 'paintbrush',
       items: [
-        { value: 'disabled', title: 'Disabled' },
-        { value: 'enabled', title: 'Enabled' }
+        { value: 'disabled', title: 'Bedrock disabled' },
+        { value: 'enabled', title: 'Bedrock enabled' }
       ]
     }
   }