Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing data-garden-id on Menu Item Icon #1128

Closed
agrohs opened this issue Jul 8, 2021 · 1 comment · Fixed by #1158
Closed

Missing data-garden-id on Menu Item Icon #1128

agrohs opened this issue Jul 8, 2021 · 1 comment · Fixed by #1158
Assignees

Comments

@agrohs
Copy link

agrohs commented Jul 8, 2021

<StyledItemIcon isCompact={isCompact} isVisible={isSelected} isDisabled={disabled}>

Is it possible to add a data-garden-id to the Icon for a selected menu item so it can be targeted by css selector outside?? In previous garden versions where these were inserted via a pseduo selector they could easily be found, but in the new setup without a data-garden-id on the StyledItemIcon its quite a pain.

@agrohs agrohs changed the title Missing data-garden-id on Menu Item Icon? Missing data-garden-id on Menu Item Icon Jul 8, 2021
@hzhu hzhu self-assigned this Jul 13, 2021
@hzhu
Copy link
Contributor

hzhu commented Jul 15, 2021

Hey @agrohs, thanks for bringing this to our attention. In the meantime, would you be able to style the icon using a scoped styled component? Here's an example: https://codesandbox.io/s/gifted-rhodes-0fc8w.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants