fix(dropdowns): add missing data-garden- attributes to menu item icon elements #1158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzempel
commented
Jul 22, 2021
| } | ||
| }} | ||
| > | ||
| <Dropdown isOpen={isOpen || undefined}> |
There was a problem hiding this comment.
I realize this treatment flips the component between controlled and uncontrolled (and results in a warning). But that's the point – the control demonstrates both uses. More importantly, we have the ability to observe and use dev tools to debug the menu items which is imperative for the storybook demo.
There was a problem hiding this comment.
I think a more suitable structure would be to demonstrate one of each usage per story — similar to the accordion stories. Probably not the right time for re-structuring, but just wanted to throw the idea out there.
There was a problem hiding this comment.
Perhaps. This directly copies the Default dropdowns story. So we may want to address both.
hzhu
approved these changes
Jul 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add missing
data-garden-[id/version]attributes toStyledItemIconcomponents.Detail
Closes #1128
Checklist
design updates are Garden Designer approved (add thedesigner as a reviewer)
yarn start)renders as expected with reversed (RTL) directionrenders as expected with Bedrock CSS (?bedrock)analyzed via axe and evaluated using VoiceOverincludes new unit teststested in Chrome, Firefox, Safari, Edge, and IE11