Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(typography): prevent monospace Code and Span from pixel shifting line heights #1023

Merged
merged 5 commits into from
Mar 1, 2021
Merged

fix(typography): prevent monospace Code and Span from pixel shifting line heights #1023

merged 5 commits into from
Mar 1, 2021

Conversation

jzempel
Copy link
Member

@jzempel jzempel commented Feb 27, 2021

Description

Reduce monospace line-height by 1px or set to normal when typography is inherited.

Detail

https://stackoverflow.com/a/8395743

Checklist

  • 👌 design updates are Garden Designer approved (add the
    designer as a reviewer)
  • 🌐 demo is up-to-date (yarn start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • 🤘 renders as expected with Bedrock CSS (?bedrock)
  • ♿ analyzed via axe and evaluated using VoiceOver
  • 💂‍♂️ includes new unit tests
  • 📝 tested in Chrome, Firefox, Safari, Edge, and IE11

@jzempel jzempel requested a review from a team as a code owner February 27, 2021 20:29
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.632% when pulling 4c73572 on jzempel/code-shift into 1ff5ae7 on main.

@zendesk-garden zendesk-garden temporarily deployed to staging February 27, 2021 20:58 Inactive
@jzempel jzempel merged commit ce56c63 into main Mar 1, 2021
@jzempel jzempel deleted the jzempel/code-shift branch March 1, 2021 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzhu hzhu hzhu approved these changes

@m-lai m-lai m-lai approved these changes

@allisonacs allisonacs Awaiting requested review from allisonacs

Assignees
No one assigned
Labels
PR: Bug Fix 🐛
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jzempel @coveralls @hzhu @m-lai @zendesk-garden