Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(colorpickers): prevent subpixel slider height increase #1034

Merged
merged 2 commits into from
Mar 11, 2021
Merged

fix(colorpickers): prevent subpixel slider height increase #1034

merged 2 commits into from
Mar 11, 2021

Conversation

jzempel
Copy link
Member

@jzempel jzempel commented Mar 11, 2021

Description

This small change prevents the Field-wrapped range inputs from adding subpixel height. With bedrock enabled, these fields are currently bumping to 22.33px. This change constrains the height to the expected 22px.

@jzempel jzempel requested a review from a team as a code owner March 11, 2021 17:29
@coveralls
Copy link

Coverage Status

Coverage increased (+0.0005%) to 95.12% when pulling 97d8ae0 on jzempel/height-fix into 1c7f6ac on main.

@zendesk-garden zendesk-garden temporarily deployed to staging March 11, 2021 18:04 Inactive
@jzempel jzempel merged commit b24b687 into main Mar 11, 2021
@jzempel jzempel deleted the jzempel/height-fix branch March 11, 2021 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austingreendev austingreendev austingreendev approved these changes

Assignees
No one assigned
Labels
PR: Bug Fix 🐛
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jzempel @coveralls @austingreendev @zendesk-garden