Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(notifications): allow placement customizations for toast #1055

Merged
merged 3 commits into from
Mar 24, 2021
Merged

feat(notifications): allow placement customizations for toast #1055

merged 3 commits into from
Mar 24, 2021

Conversation

austingreendev
Copy link
Contributor

@austingreendev austingreendev commented Mar 24, 2021 •
edited

Description

This PR adds the ability to apply custom props (and styles) to individual placement slots in the Toast notification. This can help with custom positioning if required by consumers.

Checklist

  • 👌 design updates are Garden Designer approved (add the
    designer as a reviewer)
  • 🌐 demo is up-to-date (yarn start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • 🤘 renders as expected with Bedrock CSS (?bedrock)
  • ♿ analyzed via axe and evaluated using VoiceOver
  • 💂‍♂️ includes new unit tests
  • 📝 tested in Chrome, Firefox, Safari, Edge, and IE11

@austingreendev austingreendev requested a review from a team March 24, 2021 16:54
@coveralls
Copy link

coveralls commented Mar 24, 2021 •
edited

Coverage Status

Coverage increased (+0.0005%) to 95.157% when pulling b21d14d on agreen/toast-customizations into 54799bb on main.

@zendesk-garden zendesk-garden temporarily deployed to staging March 24, 2021 18:50 Inactive
@austingreendev austingreendev marked this pull request as ready for review March 24, 2021 19:17
jzempel
jzempel requested changes Mar 24, 2021
View reviewed changes
Copy link
Member

@jzempel jzempel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor doc change

packages/notifications/src/elements/toaster/ToastProvider.tsx Outdated Show resolved Hide resolved
@zendesk-garden zendesk-garden temporarily deployed to staging March 24, 2021 20:50 Inactive
@austingreendev austingreendev merged commit 7a2267b into main Mar 24, 2021
@austingreendev austingreendev deleted the agreen/toast-customizations branch March 24, 2021 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzempel jzempel jzempel approved these changes

@hzhu hzhu hzhu approved these changes

Assignees
No one assigned
Labels
PR: New Feature 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@austingreendev @coveralls @jzempel @hzhu @zendesk-garden