Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dropdowns): handle combobox controlled open #1083

Merged
merged 2 commits into from
May 6, 2021
Merged

fix(dropdowns): handle combobox controlled open #1083

merged 2 commits into from
May 6, 2021

Conversation

jzempel
Copy link
Member

@jzempel jzempel commented May 5, 2021

Description

The original intent of this PR was to add isOpen controls for debugging storybook dropdown demos. However, it brought to light a missing useEffect on Combobox for focusing the input when isOpen is set to true.

@jzempel jzempel requested a review from a team as a code owner May 5, 2021 18:01
@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 95.142% when pulling b175872 on jzempel/dropdowns-open into 72d6a8f on main.

@zendesk-garden zendesk-garden temporarily deployed to staging May 5, 2021 18:32 Inactive
@jzempel jzempel merged commit 261964d into main May 6, 2021
@jzempel jzempel deleted the jzempel/dropdowns-open branch May 6, 2021 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzhu hzhu hzhu approved these changes

Assignees
No one assigned
Labels
PR: Bug Fix 🐛
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jzempel @coveralls @hzhu @zendesk-garden