Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(forms, buttons): finesse component group z-index transitions #1091

Merged
merged 6 commits into from
May 22, 2021
Merged

fix(forms, buttons): finesse component group z-index transitions #1091

merged 6 commits into from
May 22, 2021

Conversation

jzempel
Copy link
Member

@jzempel jzempel commented May 21, 2021

Description

Finesse z-index transitions for InputGroup and ButtonGroup.

Checklist

  • 👌 design updates are Garden Designer approved (add the
    designer as a reviewer)
  • 🌐 demo is up-to-date (yarn start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • 🤘 renders as expected with Bedrock CSS (?bedrock)
  • ♿ analyzed via axe and evaluated using VoiceOver
  • 💂‍♂️ includes new unit tests
  • 📝 tested in Chrome, Firefox, Safari, Edge, and IE11

@jzempel jzempel requested a review from a team as a code owner May 21, 2021 23:34
@zendesk-garden zendesk-garden temporarily deployed to staging May 22, 2021 00:10 Inactive
hzhu
hzhu approved these changes May 22, 2021
View reviewed changes
Copy link
Contributor

@hzhu hzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jzempel jzempel merged commit 41716a9 into main May 22, 2021
@jzempel jzempel deleted the jzempel/group-transition branch May 22, 2021 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allisonacs allisonacs allisonacs approved these changes

@hzhu hzhu hzhu approved these changes

@nchieng nchieng Awaiting requested review from nchieng

Assignees
No one assigned
Labels
PR: Bug Fix 🐛
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jzempel @allisonacs @hzhu @zendesk-garden