Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency @types/react to v17.0.11 #1097

Merged
merged 2 commits into from
Jun 28, 2021
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 24, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@types/react 17.0.2 -> 17.0.11 age adoption passing confidence

Configuration

πŸ“… Schedule: "on Monday every 8 weeks of the year starting on the 5th week" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

β™» Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

πŸ”• Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner May 24, 2021 04:42
@renovate renovate bot force-pushed the renovate/react-17.x branch 9 times, most recently from 742bc7e to 166330b Compare May 25, 2021 12:55
@renovate renovate bot changed the title chore(deps): update dependency @types/react to v17.0.6 chore(deps): update dependency @types/react to v17.0.7 May 25, 2021
@renovate renovate bot force-pushed the renovate/react-17.x branch 11 times, most recently from 08be875 to 56a5792 Compare May 26, 2021 01:59
@renovate renovate bot changed the title chore(deps): update dependency @types/react to v17.0.7 chore(deps): update dependency @types/react to v17.0.8 May 26, 2021
@renovate renovate bot force-pushed the renovate/react-17.x branch 5 times, most recently from 96c47e7 to 5d88ebc Compare June 2, 2021 03:05
@renovate renovate bot changed the title chore(deps): update dependency @types/react to v17.0.8 chore(deps): update dependency @types/react to v17.0.9 Jun 2, 2021
@renovate renovate bot changed the title chore(deps): update dependency @types/react to v17.0.9 chore(deps): update dependency @types/react to v17.0.10 Jun 9, 2021
@renovate renovate bot changed the title chore(deps): update dependency @types/react to v17.0.10 chore(deps): update dependency @types/react to v17.0.11 Jun 9, 2021
@renovate renovate bot force-pushed the renovate/react-17.x branch 2 times, most recently from ac13f3d to d1f9891 Compare June 23, 2021 13:38
@hzhu
Copy link
Contributor

hzhu commented Jun 28, 2021

Overview

Garden's sub-packages must support the latest version of @types/react that was installed at the root level, in this case, v17.0.11. If the dependencies (managed by root level and sub-package level yarn.lock files) are out of sync, TS warnings will be thrown. Here are the steps to bring sub-package level yarn.lock files in sync with root yarn.lock.

Solution

  1. yarn install at root to ensure latest dependencies
  2. yarn tsc shows TypeScript warnings relating to sub-packages πŸ›‘
  3. Locate out-of-date sub-package dependencies
    1. Each sub-package has a dependency that has installed an out-dated version of @types/react
    2. Run in sub-package: yarn install and yarn upgrade to upgrade the yarn.lock file
  4. Repeat for every sub-package that throws TS warnings
  5. Run npx yarn-deduplicate at the root level if needed to de-duplicate yarn.lock
  6. Run yarn tsc, there should be no TypeScript warnings πŸŽ‰

Example

Screen Shot 2021-06-28 at 8 45 26 AM

  1. Identify which dependency dictates the outdated @types/react version in packages/tables/yarn.lock
  2. Identified that react-window is the dependency in question
  3. Run yarn remove react-window & verify @types/react is removed from packages/tables/yarn.lock
  4. Run yarn add react-window (ensure the version is the same as before)
  5. Verify that the packages/tables/yarn.lock is now updated to contain @types/react version 17.0.11

@zendesk-garden zendesk-garden temporarily deployed to staging June 28, 2021 15:38 Inactive
@hzhu hzhu merged commit d4fd7bc into main Jun 28, 2021
@hzhu hzhu deleted the renovate/react-17.x branch June 28, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants