Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pagination): page disabled and background color transition styling #1157

Merged
merged 3 commits into from
Jul 22, 2021
Merged

fix(pagination): page disabled and background color transition styling #1157

merged 3 commits into from
Jul 22, 2021

Conversation

jzempel
Copy link
Member

@jzempel jzempel commented Jul 22, 2021

Description

Fix for disabled pages showing a pointer cursor on hover and background-color transition not being correctly applied.

Checklist

  • 👌 design updates are Garden Designer approved (add the
    designer as a reviewer)
  • 🌐 demo is up-to-date (yarn start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • 🤘 renders as expected with Bedrock CSS (?bedrock)
  • ♿ analyzed via axe and evaluated using VoiceOver
  • 💂‍♂️ includes new unit tests
  • 📝 tested in Chrome, Firefox, Safari, Edge, and IE11

@jzempel jzempel requested a review from a team as a code owner July 22, 2021 14:50
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.001%) to 94.842% when pulling 38c3b78 on jzempel/pagination-cursor into b54fbce on main.

@zendesk-garden zendesk-garden temporarily deployed to staging July 22, 2021 15:13 Inactive
@jzempel jzempel merged commit 7f56ecf into main Jul 22, 2021
@jzempel jzempel deleted the jzempel/pagination-cursor branch July 22, 2021 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzhu hzhu hzhu approved these changes

Assignees
No one assigned
Labels
PR: Bug Fix 🐛
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jzempel @coveralls @hzhu @zendesk-garden