fix(types): export IAvatarProps and ILabelProps #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtomcal
commented
Sep 23, 2021
packages/dropdowns/src/index.ts
Outdated
| @@ -28,5 +28,5 @@ export { MediaItem } from './elements/Menu/Items/MediaItem'; | |||
| export { NextItem } from './elements/Menu/Items/NextItem'; | |||
| export { PreviousItem } from './elements/Menu/Items/PreviousItem'; | |||
| export type { GARDEN_PLACEMENT, POPPER_PLACEMENT } from './utils/garden-placements'; | |||
|
|
|||
| export type { ILabelProps } from './elements/Fields/Label'; | |||
There was a problem hiding this comment.
Do we need to export all interfaces from these subcomponents in Dropdown retroactively? 🤔
There was a problem hiding this comment.
All applicable element interfaces should be exported. See https://github.com/zendeskgarden/react-components/blob/main/packages/buttons/src/index.ts
|
+1! We are Typescriptfying some components that are wrappers for some of the Dropdown components and it would help a lot if we had these! |
jzempel
approved these changes
Sep 24, 2021
Francois-Esquire
approved these changes
Sep 24, 2021
hzhu
approved these changes
Sep 24, 2021
|
Added all available interfaces to the export for dropdown. For other components, we can open up new PRs for that. At present course, this will go out in next week's release on Wed 29th. |
Francois-Esquire
approved these changes
Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some developers need access to
ILabelPropsandIAvatarPropsin order to extend them.ILabelPropsIAvatarPropsChecklist
designer as a reviewer)
yarn start)?bedrock)