Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(chrome): update size snapshot #1252

Merged
merged 1 commit into from
Dec 1, 2021
Merged

chore(chrome): update size snapshot #1252

merged 1 commit into from
Dec 1, 2021

Conversation

Francois-Esquire
Copy link
Contributor

Description

Updating chrome size snapshot.

Detail

After the Sheet feature for chrome was merged, the snapshot caused the tests on main to fail. This fixes CI for the branch.

Checklist

  • 👌 design updates are Garden Designer approved (add the
    designer as a reviewer)
  • 🌐 demo is up-to-date (yarn start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • 🤘 renders as expected with Bedrock CSS (?bedrock)
  • ♿ analyzed via axe and evaluated using VoiceOver
  • 💂‍♂️ includes new unit tests
  • 📝 tested in Chrome, Firefox, Safari, Edge, and IE11

@Francois-Esquire Francois-Esquire requested a review from a team as a code owner November 30, 2021 22:29
@Francois-Esquire Francois-Esquire merged commit 40cdf81 into main Dec 1, 2021
@Francois-Esquire Francois-Esquire deleted the francois-esquire/chrome-size-snapshot-fix branch December 1, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzhu hzhu hzhu approved these changes

@smritimadan smritimadan smritimadan approved these changes

Assignees
No one assigned
Labels
PR: Internal 🌱
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Francois-Esquire @hzhu @smritimadan @zendesk-garden